Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap
From: Michael Ellerman
Date: Fri May 19 2017 - 06:04:39 EST
Michael Ellerman <mpe@xxxxxxxxxxxxxx> writes:
> Pavel Machek <pavel@xxxxxxx> writes:
>> On Wed 2017-05-17 14:37:17, Andrew Morton wrote:
>>> On Wed, 17 May 2017 14:06:13 +0200 Pavel Machek <pavel@xxxxxxx> wrote:
>>> > On Sun 2017-04-02 12:05:36, Pavel Machek wrote:
>>> > > Fix overlapping NAND partitions.
>>> > >
>>> > > Signed-off-by: Pavel Machek <pavel@xxxxxx>
>>> > Ping? Two partitions at same place are bad news...
>>> Please expand on "bad news"? What are the runtime effects of this
>>> change? Decisions about which kernel(s) to patch depend on this info.
>> Well... two partitions at same place. If you use one, you will corrupt
>> information on the other one.
>> OTOH this moves partition around (so that they don't overlap) so it is
>> probably not stable candidate.
>> I guess this is not huge issue; people using these boards probably
>> have custom dts changes, anyway...
> Or no one's even using it anymore.
> I can take this via powerpc, I won't mark it for stable etc.
Author: Pavel Machek <pavel@xxxxxxx>
powerpc/sequoia: Fix NAND partitions not to overlap
Currently the DTS defines two partitions at the same addresses, if you
use one, you will corrupt information on the other one. Fix it by
shifting the second partition.
Signed-off-by: Pavel Machek <pavel@xxxxxx>
[mpe: Reconstruct change log from email thread]
Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
Minor nit, your From: address doesn't match your Signed-off-by: address,
which trips my "check patch is signed-off-by author" script. I can
just ignore it, but I think it's preferable if they match.