Re: [PATCH] mmc: sdhci-iproc: suppress spurious interrupt with Multiblock read

From: Srinath Mannam
Date: Mon May 22 2017 - 09:33:24 EST


On Mon, May 22, 2017 at 5:31 PM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> On 22 May 2017 at 13:52, Srinath Mannam <srinath.mannam@xxxxxxxxxxxx> wrote:
>> On Fri, May 19, 2017 at 11:55 AM, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:
>>> On 18/05/17 19:57, Srinath Mannam wrote:
>>>> The stingray SDHCI hardware supports ACMD12 and automatically
>>>> issues after multi block transfer completed.
>>>>
>>>> If ACMD12 in SDHCI is disabled, spurious tx done interrupts are seen
>>>> on multi block read command with below error message:
>>>>
>>>> Got data interrupt 0x00000002 even though no data
>>>> operation was in progress.
>>>>
>>>> This patch uses SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 to enable
>>>> ACM12 support in SDHCI hardware and suppress spurious interrupt.
>>>>
>>>> Signed-off-by: Srinath Mannam <srinath.mannam@xxxxxxxxxxxx>
>>>> Reviewed-by: Ray Jui <ray.jui@xxxxxxxxxxxx>
>>>> Reviewed-by: Scott Branden <scott.branden@xxxxxxxxxxxx>
>>>
>>> Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
>>
>> Thanks Adrian...
>>
>> Will it be possible to take this for Linux-4.12??
>
> It's queued for 4.13, however are you saying it's a regression for
> 4.12? Then what commit fixes it?
>
> Perhaps you even want this to go stable?
>
> Kind regards
> Uffe

Yes, this is regression for 4.12.
Fixes: b580c52d58d9 ("mmc: sdhci-iproc: add IPROC SDHCI driver")
Yes we want this to go in stable.

Thank you.

Regards,
Srinath.