Re: [PATCH] kernel: bpf: remove dead code

From: David Miller
Date: Mon May 22 2017 - 10:38:12 EST


From: "Gustavo A. R. Silva" <garsilva@xxxxxxxxxxxxxx>
Date: Mon, 22 May 2017 09:07:46 -0500

> Execution cannot reach NET_IP_ALIGN inside the following statement:
> ip_align = strict ? 2 : NET_IP_ALIGN
>
> Addresses-Coverity-ID: 1409762
> Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>
> ---
> NOTE: variable ip_align could also be removed and use value 2 directly.

Incorrect.

Some platforms define NET_IP_ALIGN to zero, so the code must remain
as is.