Re: [PATCH v3 0/5] mtd: mchp23k256: device tree and mchp23lcv1024

From: Boris Brezillon
Date: Tue May 23 2017 - 03:40:13 EST


On Tue, 23 May 2017 12:43:12 +1200
Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> wrote:

> This series adds device tree support to the mchp23k256 driver and
> support for the mchp23lcv1024 chip. I suspect there are more compatible
> variants that we could now enumerate if desired.
>
> Chris Packham (5):
> mtd: mchp23k256: Add OF device ID table
> mtd: mchp23k256: switch to mtd_device_register()
> mtd: handle partitioning on devices with 0 erasesize
> mtd: mchp23k256: add partitioning support
> mtd: mchp23k256: Add support for mchp23lcv1024

Shouldn't we add a spi_device_id table to allow non-DT users to probe
mchp23lcv1024 chips?

>
> .../bindings/mtd/microchip,mchp23k256.txt | 18 ++++++
> drivers/mtd/devices/mchp23k256.c | 65 ++++++++++++++++++----
> drivers/mtd/mtdpart.c | 25 ++++++---
> 3 files changed, 87 insertions(+), 21 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mtd/microchip,mchp23k256.txt
>