Re: [PATCH v11 8/9] arm64: dts: hi6220: register debug module

[Mathieu Poirier]

On 23 May 2017 at 08:16, Leo Yan <leo.yan@xxxxxxxxxx> wrote:
> Bind debug module driver for Hi6220.
>
> Reviewed-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
> Signed-off-by: Leo Yan <leo.yan@xxxxxxxxxx>

Wei and Mark,

I think it makes sense to have this go through the coresight tree
along with the rest of the driver.  Please have a look and let me
know.

Thanks,
Mathieu

> ---
>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 64 +++++++++++++++++++++++++++++++
>  1 file changed, 64 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 1e5129b..21805b9 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -916,5 +916,69 @@
>                                 };
>                         };
>                 };
> +
> +               debug@f6590000 {
> +                       compatible = "arm,coresight-cpu-debug","arm,primecell";
> +                       reg = <0 0xf6590000 0 0x1000>;
> +                       clocks = <&sys_ctrl HI6220_DAPB_CLK>;
> +                       clock-names = "apb_pclk";
> +                       cpu = <&cpu0>;
> +               };
> +
> +               debug@f6592000 {
> +                       compatible = "arm,coresight-cpu-debug","arm,primecell";
> +                       reg = <0 0xf6592000 0 0x1000>;
> +                       clocks = <&sys_ctrl HI6220_DAPB_CLK>;
> +                       clock-names = "apb_pclk";
> +                       cpu = <&cpu1>;
> +               };
> +
> +               debug@f6594000 {
> +                       compatible = "arm,coresight-cpu-debug","arm,primecell";
> +                       reg = <0 0xf6594000 0 0x1000>;
> +                       clocks = <&sys_ctrl HI6220_DAPB_CLK>;
> +                       clock-names = "apb_pclk";
> +                       cpu = <&cpu2>;
> +               };
> +
> +               debug@f6596000 {
> +                       compatible = "arm,coresight-cpu-debug","arm,primecell";
> +                       reg = <0 0xf6596000 0 0x1000>;
> +                       clocks = <&sys_ctrl HI6220_DAPB_CLK>;
> +                       clock-names = "apb_pclk";
> +                       cpu = <&cpu3>;
> +               };
> +
> +               debug@f65d0000 {
> +                       compatible = "arm,coresight-cpu-debug","arm,primecell";
> +                       reg = <0 0xf65d0000 0 0x1000>;
> +                       clocks = <&sys_ctrl HI6220_DAPB_CLK>;
> +                       clock-names = "apb_pclk";
> +                       cpu = <&cpu4>;
> +               };
> +
> +               debug@f65d2000 {
> +                       compatible = "arm,coresight-cpu-debug","arm,primecell";
> +                       reg = <0 0xf65d2000 0 0x1000>;
> +                       clocks = <&sys_ctrl HI6220_DAPB_CLK>;
> +                       clock-names = "apb_pclk";
> +                       cpu = <&cpu5>;
> +               };
> +
> +               debug@f65d4000 {
> +                       compatible = "arm,coresight-cpu-debug","arm,primecell";
> +                       reg = <0 0xf65d4000 0 0x1000>;
> +                       clocks = <&sys_ctrl HI6220_DAPB_CLK>;
> +                       clock-names = "apb_pclk";
> +                       cpu = <&cpu6>;
> +               };
> +
> +               debug@f65d6000 {
> +                       compatible = "arm,coresight-cpu-debug","arm,primecell";
> +                       reg = <0 0xf65d6000 0 0x1000>;
> +                       clocks = <&sys_ctrl HI6220_DAPB_CLK>;
> +                       clock-names = "apb_pclk";
> +                       cpu = <&cpu7>;
> +               };
>         };
>  };
> --
> 2.7.4
>