[PATCH 19/20] ipc/sem: Drop __sem_free()

From: Manfred Spraul
Date: Thu May 25 2017 - 14:52:47 EST


From: Kees Cook <keescook@xxxxxxxxxxxx>

The remaining users of __sem_free() can simply call kvfree() instead for
better readability.

Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>

[manfred@xxxxxxxxxxxxxxxx: Rediff to keep rcu protection for
security_sem_alloc()]
Signed-off-by: Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>
---
ipc/sem.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/ipc/sem.c b/ipc/sem.c
index 5f13773..9e70cd7 100644
--- a/ipc/sem.c
+++ b/ipc/sem.c
@@ -258,18 +258,13 @@ static void merge_queues(struct sem_array *sma)
}
}

-static void __sem_free(struct sem_array *sma)
-{
- kvfree(sma);
-}
-
static void sem_rcu_free(struct rcu_head *head)
{
struct kern_ipc_perm *p = container_of(head, struct kern_ipc_perm, rcu);
struct sem_array *sma = container_of(p, struct sem_array, sem_perm);

security_sem_free(sma);
- __sem_free(sma);
+ kvfree(sma);
}

/*
@@ -500,7 +495,7 @@ static int newary(struct ipc_namespace *ns, struct ipc_params *params)
sma->sem_perm.security = NULL;
retval = security_sem_alloc(sma);
if (retval) {
- __sem_free(sma);
+ kvfree(sma);
return retval;
}

--
2.9.3