Re: [PATCH v8] mfd: Add Cherry Trail Whiskey Cove PMIC driver

From: Andy Shevchenko
Date: Tue May 30 2017 - 09:06:06 EST


On Tue, 2017-05-30 at 13:20 +0100, Lee Jones wrote:
> On Tue, 30 May 2017, Andy Shevchenko wrote:
>
> > On Tue, May 30, 2017 at 12:02 PM, Lee Jones <lee.jones@xxxxxxxxxx>
> > wrote:
> > > On Tue, 23 May 2017, Hans de Goede wrote:
> > > > +static const struct i2c_device_id cht_wc_i2c_id[] = {
> > > > +ÂÂÂÂÂ{ }
> > > > +};
> > >
> > > What's the point in this empty table?
> >
> > This is artifact of I2C framework, otherwise if will be not
> > enumerated.
> >
> > +Wolfram.
> >
> > Wolfram, can we fix this? (In case we have either ACPI table or OF
> > table there is no need to oblige providing empty legacy table)
>
> I think I fixed this already.
>
> Hint: `git grep probe_new -- drivers/i2c`

Indeed.
Thanks for a hint!

--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy