Re: [PATCH v5 06/10] x86/hyper-v: implement rep hypercalls

From: Andy Shevchenko
Date: Tue May 30 2017 - 12:33:50 EST


On Tue, May 30, 2017 at 2:34 PM, Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> wrote:
> Rep hypercalls are normal hypercalls which perform multiple actions at
> once. Hyper-V guarantees to return exectution to the caller in not more
> than 50us and the caller needs to use hypercall continuation. Touch NMI
> watchdog between hypercall invocations.
>
> This is going to be used for HvFlushVirtualAddressList hypercall for
> remote TLB flushing.


> + control |= (u64)varhead_size << 17; /* Variable header size */
> + control |= (u64)rep_count << 32; /* Rep Count */

> + control &= U64_MAX >> 16;
> + control |= (u64)rep_comp << 48;

It might make sense to define magics with appropriate names.

--
With Best Regards,
Andy Shevchenko