Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure

From: Stephen Rothwell
Date: Wed May 31 2017 - 18:03:48 EST


Hi Tony, Andrew,

On Wed, 31 May 2017 12:02:10 -0700 Tony Lindgren <tony@xxxxxxxxxxx> wrote:
>
> * Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> [170531 11:21]:
> > On Wed, 31 May 2017 13:14:50 -0400 Johannes Weiner <hannes@xxxxxxxxxxx> wrote:
> >
> > > Andrew, the 0day tester found a crash with this when special pages get
> > > faulted. They're not charged to any cgroup and we'll deref NULL.
> > >
> > > Can you include the following fix on top of this patch please? Thanks!
> >
> > OK. But this won't fix the init ordering crash which the arm folks are
> > seeing?
>
> That's correct, the ordering crash is a separate problem.
>
> > I'm wondering if we should ask Stephen to drop
> >
> > mm-vmstat-move-slab-statistics-from-zone-to-node-counters.patch
> > mm-memcontrol-use-the-node-native-slab-memory-counters.patch
> > mm-memcontrol-use-generic-mod_memcg_page_state-for-kmem-pages.patch
> > mm-memcontrol-per-lruvec-stats-infrastructure.patch
> > mm-memcontrol-account-slab-stats-per-lruvec.patch
> >
> > until that is sorted?
>
> Seems like a good idea.

OK, I have removed them.

--
Cheers,
Stephen Rothwell