Re: [PATCH v3 03/17] mfd: madera: Add common support for Cirrus Logic Madera codecs

From: Joe Perches
Date: Mon Jun 05 2017 - 06:40:20 EST


On Mon, 2017-06-05 at 11:32 +0100, Lee Jones wrote:
> On Fri, 02 Jun 2017, Richard Fitzgerald wrote:
[]
> > if (IS_ERR(madera->reset_gpio))
> > + ret = PTR_ERR(madera->reset_gpio);
> > + else
> > + ret = 0;
>
> If you pre-initialise ret, you can drop the else.

Better to use:

ret = PTR_ERR_OR_ZERO(madera->reset_gpio);