Re: [kernel-hardening] Re: [PATCH 3.18 01/33] Revert "stackprotector: Increase the per-task stack canarys random range from 32 bits to 64 bits on 64-bit platforms"

From: Greg Kroah-Hartman
Date: Tue Jun 06 2017 - 03:21:46 EST


On Mon, Jun 05, 2017 at 01:06:52PM -0700, Eric Biggers wrote:
> On Mon, Jun 05, 2017 at 12:13:11PM -0700, Kees Cook wrote:
> > On Mon, Jun 5, 2017 at 9:16 AM, Greg Kroah-Hartman
> > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > > 3.18-stable review patch. If anyone has any objections, please let me know.
> > >
> > > ------------------
> > >
> > > From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > >
> > > This reverts commit 609a3e81550b0b4ea87197b0f59455a7bcff975a which is
> > > commit 5ea30e4e58040cfd6434c2f33dc3ea76e2c15b05 upstream.
> > >
> > > It shouldn't have been backported to 3.18, as we do not have
> > > get_random_long() in that kernel tree.
> >
> > It should be possible to trivially backport
> > ec9ee4acd97c0039a61c0ae4f12705767ae62153 to gain get_random_long().
> >
> > -Kees
>
> If that's done it may be a good idea to take
> b1132deac01c2332d234fa821a70022796b79182 as well, which fixed an alignment bug
> in get_random_long().

Good idea for both of these, I'll do that in the next round of releases.

thanks,

greg k-h