Re: [PATCH] arm: aspeed: Add clock-names property to timer node

From: Arnd Bergmann
Date: Tue Jun 06 2017 - 05:41:17 EST


On Mon, Jun 5, 2017 at 10:59 AM, Joel Stanley <joel@xxxxxxxxx> wrote:
> On Mon, Jun 5, 2017 at 5:18 PM, Andrew Jeffery <andrew@xxxxxxxx> wrote:
>> The merging of a number of clocksource drivers into fttmr010 means we
>> require clock-names to be specified in the Aspeed timer node, else the
>> clocksource fails to probe and boot hangs.
>
> Arnd,
>
> Linus' reworked timer driver will go into 4.13.
>
> Can we get this patch merged into 4.12 as a fix so we don't end up
> with a broken boot at any stage?

Hmm, can't we make the driver backward-compatible and have it fall
back on the first clock if no clk named "PCLK" is found? Otherwise
you still have an incompatible change in the DT binding and it will
break if someone uses an older dtb with a newer kernel.

Arnd