Re: [RFC PATCH v1] irqchip: Add support for tango interrupt router

From: Thomas Petazzoni
Date: Tue Jun 06 2017 - 11:52:25 EST


Hello,

On Tue, 6 Jun 2017 15:42:36 +0200, Mason wrote:

> + interrupt-controller@6f800 {
> + compatible = "sigma,smp8759-intc";
> + reg = <0x6f800 0x430>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + interrupt-parent = <&gic>;
> + /*
> + * There probably is a better way than explicitly listing
> + * the 24 interrupts?
> + */

What we do on Marvell platforms is:

marvell,spi-base = <128>, <136>, <144>, <152>;

see marvell,odmi-controller.txt.

In another driver I submitted, we're doing:

marvell,spi-ranges = <64 64>, <288 64>;

Retrospectively, I would have preferred to use marvell,spi-ranges for
the first DT binding as well, since it allows to express both the base
and number of interrupts available in the range.

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com