Re: [PATCH][net-next] net/mlxfw: remove redundant goto on error check

From: David Miller
Date: Tue Jun 06 2017 - 12:22:56 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Tue, 6 Jun 2017 11:47:40 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The check to see of err is set and the subsequent goto is extraneous
> as the next statement is where the goto is jumping to. Remove this
> redundant check and goto.
>
> Detected by CoverityScan, CID#1437734 ("Identical code for
> different branches")
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied, thanks.