Re: [PATCH v2] firmware: fix sending -ERESTARTSYS due to signal on fallback

From: Andy Lutomirski
Date: Wed Jun 07 2017 - 00:57:15 EST


On Tue, Jun 6, 2017 at 5:22 PM, Luis R. Rodriguez <mcgrof@xxxxxxxxxx> wrote:
> On Tue, Jun 06, 2017 at 06:11:51PM -0400, Theodore Ts'o wrote:
>> On Tue, Jun 06, 2017 at 06:47:34PM +0200, Luis R. Rodriguez wrote:
>> > On Tue, Jun 06, 2017 at 03:53:16PM +0100, Alan Cox wrote:
>
> We rely on swait, and swait right now only uses -ERESTARTSYS. Are
> you saying we could mask out -ERESTARTSYS and map it to -ERESTARTNOINTR
> or -ERESTARTNOHAND if we see fit for some future functionality / need ?

I think that has essentially nothing to do with swait. User code does
some syscall. That syscall triggers a firmware load. The caller gets
a signal. If you're going to let firmware load get interrupted, you
need to consider what the syscall is.