Re: [PATCH v4 3/3] media: mtk-mdp: Fix mdp device tree

From: Matthias Brugger
Date: Wed Jun 07 2017 - 05:13:47 EST




On 07/06/17 11:11, Hans Verkuil wrote:
On 07/06/17 11:07, Matthias Brugger wrote:


On 07/06/17 10:56, Hans Verkuil wrote:
On 07/06/17 10:44, Matthias Brugger wrote:
Hi Hans, hi Mauro,

On 23/05/17 05:24, Minghsiu Tsai wrote:
From: Daniel Kurtz <djkurtz@xxxxxxxxxxxx>

If the mdp_* nodes are under an mdp sub-node, their corresponding
platform device does not automatically get its iommu assigned properly.

Fix this by moving the mdp component nodes up a level such that they are
siblings of mdp and all other SoC subsystems. This also simplifies the
device tree.

Although it fixes iommu assignment issue, it also break compatibility
with old device tree. So, the patch in driver is needed to iterate over
sibling mdp device nodes, not child ones, to keep driver work properly.

Signed-off-by: Daniel Kurtz <djkurtz@xxxxxxxxxxxx>
Signed-off-by: Minghsiu Tsai <minghsiu.tsai@xxxxxxxxxxxx>
Signed-off-by: Matthias Brugger <matthias.bgg@xxxxxxxxx>


Are you OK to take this patch, or do you have any further comments?

Nope, it's all good. Queued for 4.13.


Thanks!

I queued the other two in v4.12-next/dts64

Media bindings normally go through the media subsystem, but you've taken
that one as well? I need to know, because then I drop it in my tree.


My fault, I'll drop it from my tree. After that I only queued patch 2/3.

Sorry.
Matthias