Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

[Lee Jones]

On Wed, 07 Jun 2017, Lee Jones wrote:

> On Wed, 07 Jun 2017, Keerthy wrote:
> 
> > 
> > 
> > On Tuesday 06 June 2017 08:34 PM, Enric Balletbo Serra wrote:
> > > Hi Keerthy,
> > > 
> > > By change I was looking at this. Some comments below that I think can
> > > be applied to all patches in this series
> > > 
> > > 2017-06-06 16:45 GMT+02:00 Keerthy <j-keerthy@xxxxxx>:
> > >> Currently the driver boots only via device tree hence add a
> > >> dependency on OF.
> > >>
> > >> Signed-off-by: Keerthy <j-keerthy@xxxxxx>
> > >> ---
> > >>  drivers/mfd/Kconfig | 2 +-
> > >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > >> index 75b59f1..2d1425d 100644
> > >> --- a/drivers/mfd/Kconfig
> > >> +++ b/drivers/mfd/Kconfig
> > >> @@ -1297,7 +1297,7 @@ config MFD_TPS65090
> > >>
> > >>  config MFD_TPS65217
> > >>         tristate "TI TPS65217 Power Management / White LED chips"
> > >> -       depends on I2C
> > >> +       depends on I2C && OF
> > > 
> > > Shouldn't you add || COMPILE_TEST here ?
> > 
> > Sure.
> > 
> > > 
> > >>         select MFD_CORE
> > >>         select REGMAP_I2C
> > >>         select IRQ_DOMAIN
> > >>
> > > 
> > > I think you can remove the of_match_device checks in some drivers too
> > > 
> > > i.e:
> > > 
> > > http://elixir.free-electrons.com/linux/latest/source/drivers/mfd/tps65217.c#L330
> > 
> > Yes that and removal of unused i2c_device_id. I will follow it up once
> > this OF dependency is in.
> 
> The of_match_device() checks should be removed with the OF patch.

In fact, just squash these changes into the I2C removal patches.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog