Re: [PATCH v2 2/8] nvme: rename uuid to nguid in nvme_ns

From: Andy Shevchenko
Date: Wed Jun 07 2017 - 09:47:57 EST


On Thu, Jun 1, 2017 at 2:17 PM, Johannes Thumshirn <jthumshirn@xxxxxxx> wrote:
> The uuid field in the nvme_ns structure represents the nguid field
> from the identify namespace command. And as NVMe 1.3 introduced an
> UUID in the NVMe Namespace Identification Descriptor this will
> collide.
>
> So rename the uuid to nguid to prevent any further
> confusion. Unfortunately we export the nguid to sysfs in the uuid
> sysfs attribute, but this can't be changed anymore without possibly
> breaking existing userspace.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@xxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

I suppose it should go through UUID tree?

--
With Best Regards,
Andy Shevchenko