Re: [Xen-devel] [PATCH v2 0/3] xen/blkback: several fixes of resource management

From: Konrad Rzeszutek Wilk
Date: Wed Jun 07 2017 - 09:53:08 EST


On Wed, Jun 07, 2017 at 10:36:58PM +1000, Steven Haigh wrote:
> On Friday, 19 May 2017 1:28:46 AM AEST Juergen Gross wrote:
> > Destroying a Xen guest domain while it was doing I/Os via xen-blkback
> > leaked several resources, including references of the guest's memory
> > pages.
> >
> > This patch series addresses those leaks by correcting usage of
> > reference counts and the sequence when to free which resource.
> >
> > The series applies on top of commit 2d4456c73a487abe ("block:
> > xen-blkback: add null check to avoid null pointer dereference") in
> > Jens Axboe's tree kernel/git/axboe/linux-block.git
> >
> > V2: changed flag to type bool in patch 1 (Dietmar Hahn)
> >
> > Juergen Gross (3):
> > xen/blkback: fix disconnect while I/Os in flight
> > xen/blkback: don't free be structure too early
> > xen/blkback: don't use xen_blkif_get() in xen-blkback kthread
> >
> > drivers/block/xen-blkback/blkback.c | 3 ---
> > drivers/block/xen-blkback/common.h | 1 +
> > drivers/block/xen-blkback/xenbus.c | 15 ++++++++-------
> > 3 files changed, 9 insertions(+), 10 deletions(-)
>
> Just wanted to give this a bit of a prod.

<ugh> Ouch!

>
> Is there any plans in having this hit the kernel.org kernels?

Yes.
>
> My testing was purely on kernel 4.9 branch - but it doesn't look like this has
> shown up there yet?

Correct. I am thinking to send these to Jens around June 20th or so.