Re: [PATCH 3/3] libnvdimm: New ACPI 6.2 DSM functions

[Johannes Thumshirn]

On 06/07/2017 07:04 PM, Jerry Hoemann wrote:
> @@ -179,6 +217,10 @@ static inline const char *nvdimm_bus_cmd_name(unsigned cmd)
>  		[ND_CMD_ARS_START] = "ars_start",
>  		[ND_CMD_ARS_STATUS] = "ars_status",
>  		[ND_CMD_CLEAR_ERROR] = "clear_error",
> +		[5] = "trans_spa",
> +		[7] = "ars_err_inj",
> +		[8] = "ars_err_inj_clr",
> +		[9] = "ars_err_inj_stat",
>  		[ND_CMD_CALL] = "cmd_call",
>  	};

Can you please add the new values to the enum in uapi/ndctl.h? I don't
really like the magic numbers here.

-- 
Johannes Thumshirn                                          Storage
jthumshirn@xxxxxxx                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 NÃrnberg
GF: Felix ImendÃrffer, Jane Smithard, Graham Norton
HRB 21284 (AG NÃrnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850