Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure

[Pali RohÃr]

On Thursday 08 June 2017 19:44:39 Andy Shevchenko wrote:
> On Thu, Jun 8, 2017 at 8:42 PM, Andy Shevchenko
> 
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Thu, Jun 8, 2017 at 6:38 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> >> On Thu, 2017-06-08 at 08:16 -0700, Darren Hart wrote:
> >>> On Sat, May 27, 2017 at 11:49:22PM +0300, Andy Shevchenko wrote:
> >>> > On Sat, May 27, 2017 at 11:48 PM, Pali RohÃr
> >>> > <pali.rohar@xxxxxxxxx> wrote:
> >>> > > On Saturday 27 May 2017 15:33:14 Andy Shevchenko wrote:
> >> Perhaps
> >> 
> >>         pr_info("\t%*pE\n", (int)sizeof(g->object_id),
> >>         g->object_id);
> > 
> > It will print some noisy characters as far as I understood the
> > initial intention.
> 
> Ah, sorry, it will work, though sligtly differently. It will take
> extra argument from the stack which we can avoid. I don't expect the
> size of that growing. Pali?

ObjectID is always 2 bytes. And it should be printable ASCII (probably 
only [A-Za-z0-9_]) as it is used as ACPI method name.

Size is not going to change.

-- 
Pali RohÃr
pali.rohar@xxxxxxxxx

Attachment: signature.asc
Description: This is a digitally signed message part.