Re: [PATCH] mm: Define KB, MB, GB, TB in core VM

From: Anshuman Khandual
Date: Thu Jun 08 2017 - 22:54:34 EST


On 05/29/2017 04:25 PM, Michael Ellerman wrote:
> Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx> writes:
>>
>> So the question is are we willing to do all these changes across
>> the tree to achieve common definitions of KB, MB, GB, TB in the
>> kernel ? Is it worth ?
>
> No I don't think it's worth the churn.
>
> But have you looked at using the "proper" names, ie. KiB, MiB, GiB?
>
> AFAICS the only clash is:
>
> drivers/mtd/ssfdc.c:#define KiB(x) ( (x) * 1024L )
> drivers/mtd/ssfdc.c:#define MiB(x) ( KiB(x) * 1024L )
>
> Which would be easy to convert.

Sure, will take a look into generalizing KiB/MiB/GiB instead of
current proposal for KB/MB/GB.