Re: [PATCH v3 12/17] gpio: madera: Support Cirrus Logic Madera class codecs

From: Linus Walleij
Date: Fri Jun 09 2017 - 05:09:25 EST


On Fri, Jun 2, 2017 at 5:03 PM, Richard Fitzgerald
<rf@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

> This adds support for the GPIOs on Cirrus Logic Madera class codecs.
> Any pins not used for special functions (see the pinctrl driver) can be
> used as general single-bit input or output lines. The number of available
> GPIOs varies between codecs.
>
> Signed-off-by: Nariman Poushin <nariman@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
> Changes since V2:
> - Minor change now to use the parent MFD DT node for out DT bindings

This looks good to me
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

I can also merge it through the GPIO tree once it is clear that the
MFD portions are getting merged.

> +config GPIO_MADERA
> + bool "Cirrus Logic Madera class codecs"
> + depends on PINCTRL_MADERA

As this guards compilation until the MFD driver arrives.

Yours,
Linus Walleij