Re: [PATCH] gpio: mvebu: fix regmap_update_bits usage

From: Thomas Petazzoni
Date: Fri Jun 09 2017 - 06:04:41 EST


Hello,

On Fri, 9 Jun 2017 12:03:18 +0200, Gregory CLEMENT wrote:

> regmap_update_bits(mvchip->regs, GPIO_IO_CONF_OFF,
> - BIT(pin), 1);
> + BIT(pin), BIT(pin));
>
> return 0;
> }
> @@ -364,7 +364,7 @@ static int mvebu_gpio_direction_output(struct gpio_chip *chip, unsigned int pin,
> mvebu_gpio_set(chip, pin, value);
>
> regmap_update_bits(mvchip->regs, GPIO_IO_CONF_OFF,
> - BIT(pin), 0);
> + BIT(pin), BIT(pin));

Are you sure here? We want to clear the bit, so I guess the 0 is
appropriate, no?

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com