Re: [PATCH] VFS: Differentiate mount flags (MS_*) from internal superblock flags
From: David Howells
Date: Fri Jun 09 2017 - 12:04:48 EST
Jeff Layton <jlayton@xxxxxxxxxx> wrote:
> I guess you mean stuff like affs_fill_super which does:
>
> sb->s_flags |= MS_NODEV | MS_NOSUID;
>
> It seems like it's doing that too late to be useful.
Actually, after the change, it seems nothing actually tests SB_NOSUID,
SB_NODEV or SB_NOEXEC, so those bits should probably be removed.
I also wonder if the internal MS_ flags (eg. MS_SUBMOUNT) should be removed
from the UAPI header.
David