Re: Sleeping BUG in khugepaged for i586

From: David Rientjes
Date: Fri Jun 09 2017 - 18:38:51 EST


On Thu, 8 Jun 2017, Michal Hocko wrote:

> I would just pull the cond_resched out of __collapse_huge_page_copy
> right after pte_unmap. But I am not really sure why this cond_resched is
> really needed because the changelog of the patch which adds is is quite
> terse on details.

I'm not sure what could possibly be added to the changelog. We have
encountered need_resched warnings during the iteration. We fix these
because need_resched warnings suppress future warnings of the same type
for issues that are more important.

I can fix the i386 issue but removing the cond_resched() entirely isn't
really suitable.