Re: [PATCH] VFS: Differentiate mount flags (MS_*) from internal superblock flags

From: kbuild test robot
Date: Sat Jun 10 2017 - 14:00:03 EST


Hi David,

[auto build test WARNING on linus/master]
[also build test WARNING on v4.12-rc4]
[cannot apply to next-20170609]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/David-Howells/VFS-Differentiate-mount-flags-MS_-from-internal-superblock-flags/20170611-000825
config: x86_64-randconfig-x011-201723 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All warnings (new ones prefixed by >>):

In file included from include/linux/linkage.h:4:0,
from include/linux/fs.h:4,
from fs//cifs/connect.c:21:
fs//cifs/connect.c: In function 'compare_mount_options':
include/linux/fs.h:1266:20: error: expected ')' before numeric constant
#define SB_NOEXEC 8 /* Disallow program execution */
^
include/linux/compiler.h:160:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> fs//cifs/connect.c:2883:2: note: in expansion of macro 'if'
if ((sb->s_flags & CIFS_MS_MASK) != (mnt_data->flags & CIFS_MS_MASK))
^~
fs//cifs/cifsglob.h:561:9: note: in expansion of macro 'SB_NOEXEC'
SB_NOEXEC | SB_NOSUID | SB_NODEV)
^~~~~~~~~
fs//cifs/connect.c:2883:21: note: in expansion of macro 'CIFS_MS_MASK'
if ((sb->s_flags & CIFS_MS_MASK) != (mnt_data->flags & CIFS_MS_MASK))
^~~~~~~~~~~~
include/linux/fs.h:1266:20: error: expected ')' before numeric constant
#define SB_NOEXEC 8 /* Disallow program execution */
^
include/linux/compiler.h:160:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> fs//cifs/connect.c:2883:2: note: in expansion of macro 'if'
if ((sb->s_flags & CIFS_MS_MASK) != (mnt_data->flags & CIFS_MS_MASK))
^~
fs//cifs/cifsglob.h:561:9: note: in expansion of macro 'SB_NOEXEC'
SB_NOEXEC | SB_NOSUID | SB_NODEV)
^~~~~~~~~
fs//cifs/connect.c:2883:57: note: in expansion of macro 'CIFS_MS_MASK'
if ((sb->s_flags & CIFS_MS_MASK) != (mnt_data->flags & CIFS_MS_MASK))
^~~~~~~~~~~~
include/linux/fs.h:1266:20: error: expected ')' before numeric constant
#define SB_NOEXEC 8 /* Disallow program execution */
^
include/linux/compiler.h:160:42: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> fs//cifs/connect.c:2883:2: note: in expansion of macro 'if'
if ((sb->s_flags & CIFS_MS_MASK) != (mnt_data->flags & CIFS_MS_MASK))
^~
fs//cifs/cifsglob.h:561:9: note: in expansion of macro 'SB_NOEXEC'
SB_NOEXEC | SB_NOSUID | SB_NODEV)
^~~~~~~~~
fs//cifs/connect.c:2883:21: note: in expansion of macro 'CIFS_MS_MASK'
if ((sb->s_flags & CIFS_MS_MASK) != (mnt_data->flags & CIFS_MS_MASK))
^~~~~~~~~~~~
include/linux/fs.h:1266:20: error: expected ')' before numeric constant
#define SB_NOEXEC 8 /* Disallow program execution */
^
include/linux/compiler.h:160:42: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> fs//cifs/connect.c:2883:2: note: in expansion of macro 'if'
if ((sb->s_flags & CIFS_MS_MASK) != (mnt_data->flags & CIFS_MS_MASK))
^~
fs//cifs/cifsglob.h:561:9: note: in expansion of macro 'SB_NOEXEC'
SB_NOEXEC | SB_NOSUID | SB_NODEV)
^~~~~~~~~
fs//cifs/connect.c:2883:57: note: in expansion of macro 'CIFS_MS_MASK'
if ((sb->s_flags & CIFS_MS_MASK) != (mnt_data->flags & CIFS_MS_MASK))
^~~~~~~~~~~~
include/linux/fs.h:1266:20: error: expected ')' before numeric constant
#define SB_NOEXEC 8 /* Disallow program execution */
^
include/linux/compiler.h:171:16: note: in definition of macro '__trace_if'
______r = !!(cond); \
^~~~
>> fs//cifs/connect.c:2883:2: note: in expansion of macro 'if'
if ((sb->s_flags & CIFS_MS_MASK) != (mnt_data->flags & CIFS_MS_MASK))
^~
fs//cifs/cifsglob.h:561:9: note: in expansion of macro 'SB_NOEXEC'
SB_NOEXEC | SB_NOSUID | SB_NODEV)
^~~~~~~~~
fs//cifs/connect.c:2883:21: note: in expansion of macro 'CIFS_MS_MASK'
if ((sb->s_flags & CIFS_MS_MASK) != (mnt_data->flags & CIFS_MS_MASK))
^~~~~~~~~~~~
include/linux/fs.h:1266:20: error: expected ')' before numeric constant
#define SB_NOEXEC 8 /* Disallow program execution */
^
include/linux/compiler.h:171:16: note: in definition of macro '__trace_if'
______r = !!(cond); \
^~~~
>> fs//cifs/connect.c:2883:2: note: in expansion of macro 'if'
if ((sb->s_flags & CIFS_MS_MASK) != (mnt_data->flags & CIFS_MS_MASK))
^~
fs//cifs/cifsglob.h:561:9: note: in expansion of macro 'SB_NOEXEC'
SB_NOEXEC | SB_NOSUID | SB_NODEV)
^~~~~~~~~
fs//cifs/connect.c:2883:57: note: in expansion of macro 'CIFS_MS_MASK'
if ((sb->s_flags & CIFS_MS_MASK) != (mnt_data->flags & CIFS_MS_MASK))
^~~~~~~~~~~~

vim +/if +2883 fs//cifs/connect.c

9d002df4 Jeff Layton 2010-10-06 2867 kfree(tlink);
9d002df4 Jeff Layton 2010-10-06 2868 return;
9d002df4 Jeff Layton 2010-10-06 2869 }
d00c28de Jeff Layton 2010-04-24 2870
25c7f41e Pavel Shilovsky 2011-05-26 2871 static inline struct tcon_link *
cd51875d Pavel Shilovsky 2011-06-09 2872 cifs_sb_master_tlink(struct cifs_sb_info *cifs_sb)
cd51875d Pavel Shilovsky 2011-06-09 2873 {
cd51875d Pavel Shilovsky 2011-06-09 2874 return cifs_sb->master_tlink;
cd51875d Pavel Shilovsky 2011-06-09 2875 }
25c7f41e Pavel Shilovsky 2011-05-26 2876
25c7f41e Pavel Shilovsky 2011-05-26 2877 static int
25c7f41e Pavel Shilovsky 2011-05-26 2878 compare_mount_options(struct super_block *sb, struct cifs_mnt_data *mnt_data)
25c7f41e Pavel Shilovsky 2011-05-26 2879 {
25c7f41e Pavel Shilovsky 2011-05-26 2880 struct cifs_sb_info *old = CIFS_SB(sb);
25c7f41e Pavel Shilovsky 2011-05-26 2881 struct cifs_sb_info *new = mnt_data->cifs_sb;
25c7f41e Pavel Shilovsky 2011-05-26 2882
25c7f41e Pavel Shilovsky 2011-05-26 @2883 if ((sb->s_flags & CIFS_MS_MASK) != (mnt_data->flags & CIFS_MS_MASK))
25c7f41e Pavel Shilovsky 2011-05-26 2884 return 0;
25c7f41e Pavel Shilovsky 2011-05-26 2885
25c7f41e Pavel Shilovsky 2011-05-26 2886 if ((old->mnt_cifs_flags & CIFS_MOUNT_MASK) !=
25c7f41e Pavel Shilovsky 2011-05-26 2887 (new->mnt_cifs_flags & CIFS_MOUNT_MASK))
25c7f41e Pavel Shilovsky 2011-05-26 2888 return 0;
25c7f41e Pavel Shilovsky 2011-05-26 2889
25c7f41e Pavel Shilovsky 2011-05-26 2890 /*
5eba8ab3 Jeff Layton 2011-10-19 2891 * We want to share sb only if we don't specify an r/wsize or

:::::: The code at line 2883 was first introduced by commit
:::::: 25c7f41e9234f60af30e086278f1de7974f8816f CIFS: Migrate to shared superblock model

:::::: TO: Pavel Shilovsky <piastry@xxxxxxxxxxx>
:::::: CC: Steve French <sfrench@xxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip