Re: [PATCH] cpufreq: conservative: Allow down_threshold to take values from 1 to 10

From: Rafael J. Wysocki
Date: Mon Jun 12 2017 - 08:30:38 EST


On Monday, June 12, 2017 09:10:35 AM Viresh Kumar wrote:
> On 11-06-17, 17:28, Tomasz WilczyÅski wrote:
> > Commit 27ed3cd2ebf4cd78b198be9758c538cdede36d8a ("cpufreq: conservative:
> > Fix the logic in frequency decrease checking") removed the 10 point
> > substraction when comparing the load against down_threshold but did not
> > remove the related limit for the down_threshold value. As a result,
> > down_threshold lower than 11 is not allowed even though values from
> > 1 to 10 do work correctly too. The comment ("cannot be lower than 11
> > otherwise freq will not fall") is also not true after removing the
> > substraction.
> >
> > For this reason, allow down_threshold to take any value from 1 to 99
> > and fix the related comment.
> >
> > Signed-off-by: Tomasz WilczyÅski <twilczynski@xxxxxxxxx>
>
> Please add Fixes tag and relevant kernel release for stable tag.

Actually, the Fixes: tag would be sufficient and then adding it would be
appreciated.

No need to resend the patch, though.

Thanks,
Rafael