Re: [PATCH 0/3] x86: stack alignment for boot code and clang

From: Ingo Molnar
Date: Tue Jun 13 2017 - 02:39:32 EST



* Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote:

> This series fixes an issue with the stack of the x86 boot code not
> being aligned as intended. Further it adapts the Makefile to account
> for the fact that clang uses a different option to configure the
> stack alignment than gcc (-mstack-alignment=N vs
> -mpreferred-stack-boundary=N)
>
> Matthias Kaehlcke (3):
> kbuild: Add cc-option-no-kbuild macro
> x86/build: Use cc-option-no-kbuild for boot code compiler options
> x86/build: Specify stack alignment for clang
>
> arch/x86/Makefile | 25 +++++++++++++++++--------
> scripts/Kbuild.include | 5 +++++
> 2 files changed, 22 insertions(+), 8 deletions(-)

Looks good to me, modulo the minor comments I just made to the #3 patch.

This needs acks from the kbuild people before I can apply the fixes.

Thanks,

Ingo