Re: [PATCH v2] Kbuild: tiny correction on `make help`

From: Cao jin
Date: Tue Jun 13 2017 - 05:50:09 EST


Yamada-san,

I have a question on the current top level Makefile. There are
following lines, I have trouble to understand "firstword x$(MAKEFLAGS)"
in 2nd line, why there is a 'x' there?


ifneq ($(filter 4.%,$(MAKE_VERSION)),) # make-4
ifneq ($(filter %s ,$(firstword x$(MAKEFLAGS))),)
quiet=silent_
tools_silent=s
endif
else # make-3.8x
ifneq ($(filter s% -s%,$(MAKEFLAGS)),)
quiet=silent_
tools_silent=-s
endif
endif

I already read & understand your patch[*] and know these lines will be
modified, but I have spent quite a few days on understanding it, so I
still want to know the purpose of 'x'.

[*]https://lkml.org/lkml/2017/5/19/371

--
Sincerely,
Cao jin

On 06/06/2017 11:01 PM, Masahiro Yamada wrote:
> 2017-06-06 18:07 GMT+09:00 Cao jin <caoj.fnst@xxxxxxxxxxxxxx>:
>> The help info of `make C=1` is little confusing, make it clear.
>>
>> Signed-off-by: Cao jin <caoj.fnst@xxxxxxxxxxxxxx>
>
>
> Applied to linux-kbuild/fixes. Thanks!
>