Re: [PATCH v2] platform/x86: wmi: Fix printing info about WDG structure

From: Darren Hart
Date: Tue Jun 13 2017 - 12:53:02 EST


On Sat, Jun 10, 2017 at 02:22:50PM +0300, Andy Shevchenko wrote:
> On Sat, Jun 10, 2017 at 1:57 PM, Pali Rohár <pali.rohar@xxxxxxxxx> wrote:
> > object_id and notify_id are in one union structure and their meaning is
> > defined by flags. Therefore do not print notify_id for non-event block and
> > do not print object_id for event block. Remove also reserved member as it
> > does not have any defined meaning or type yet.
> >
> > As object_id and notify_id union members overlaps and have different types,
> > it caused that kernel print to dmesg binary data. This patch eliminates it.
> >
> > Signed-off-by: Pali Rohár <pali.rohar@xxxxxxxxx>
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

Thanks Pali, nice fix. Queued to testing.

--
Darren Hart
VMware Open Source Technology Center