Re: [PATCH v4 09/16] perf header: don't pass struct perf_file_section to process_##_feat

[Jiri Olsa]

On Mon, Jun 12, 2017 at 09:29:25PM -0700, David Carrillo-Cisneros wrote:

SNIP

>  	struct cpu_cache_level *caches;
>  	u32 cnt, i, version;
> @@ -2084,8 +2073,7 @@ static int process_cache(struct perf_file_section *section __maybe_unused,
>  struct feature_ops {
>  	int (*write)(struct feat_fd *ff, struct perf_evlist *evlist);
>  	void (*print)(struct feat_fd *ff, FILE *fp);
> -	int (*process)(struct perf_file_section *section,
> -		       struct feat_fd *ff, void *data);
> +	int (*process)(struct feat_fd *ff, void *data);
>  	const char *name;
>  	bool full_only;
>  };
> @@ -2616,9 +2604,11 @@ static int perf_file_section__process(struct perf_file_section *section,
>  				      struct perf_header *ph,
>  				      int feat, int fd, void *data)
>  {
> -	struct feat_fd ff = {
> +	struct feat_fd fdd = {

no need to rename to fdd

jirka