Re: [PATCH 3/4] mfd: tps65217: remove duplicated interrupt resources.

[Grygorii Strashko]

On 06/13/2017 03:18 AM, Enric Balletbo Serra wrote:
> Hi Grygorii,
>
> 2017-06-13 0:41 GMT+02:00 Grygorii Strashko <grygorii.strashko@xxxxxx>:
> > On 06/12/2017 04:24 PM, Enric Balletbo i Serra wrote:
> > > I don't think it makes sense to have the interrupt resources for charger
> > > and power button in two different places, the driver and the DT binding.
> > > That's confusing so remove the ones from the mfd driver in favour of
> > > having the interrupt resources only described in the DT. Having the
> > > resources in DT may help if there is or will be a similar pmic with
> > > different resource allocation.
> >
> > Wouldn't this break DT compatibility? Old DTs do not contain IRQ resources
> > and so they work only because of IRQ definitions in code.
>
> I don't think so, the DT binding [1] and [2] says that the interrupts
> proprieties are required, so the bindings that that doesn't have these
> proprieties are wrong. Also I suspect that the binding that doesn't
> define the interrupts expect the hw block disabled as the status =
> "disabled" was defined, so I don't think was his intention have i.e
> the charger active.
>
> [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/power/supply/tps65217_charger.txt
> [2] https://www.kernel.org/doc/Documentation/devicetree/bindings/input/tps65218-pwrbutton.txt

Ok. fair enough.

Anyway, personally I would prefer to remove irqs from DT, but as both 
points are valid - its up to maintainers to decide.

--
regards,
-grygorii