Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest

[Masami Hiramatsu]

Hi Shuah and Steve,

Sorry for replying so late...

On Thu, 8 Jun 2017 17:51:44 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Thu, 8 Jun 2017 15:44:08 -0600
> Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> wrote:
> 
> > > Also, did you see my reply about having the right config? You have
> > > HIST_TRIGGERS undefined but yet the histogram trigger tests all pass in
> > > your report.  
> > 
> > I did see that one. Didn't get a chance to look at that yet. Do you expect
> > the tests to be skipped in this case? Could it be that tests aren't run?
> > I will look at this and let you know what I find on my test system.
> 
> Your first email showed that they passed, which would be hard to do
> since the feature is not even enabled. ftracetest is very much set up
> to look at the existing pseudo files to determine if a feature exists
> or not, and if it does not, it returns "UNSUPPORTED". If it returned
> PASSED when the feature is not enabled, that would be a big time bug in
> the test.

As far as I can see, what Steve you saw was my result on the 4.9 stable
kernel, which had been compiled with fully ftrace enabled :).

> > 
> > > 
> > > One more thing, is this 100% reproducible. That is, does it always fail?
> > >   
> > Failed the two times I tried.

I've also tried to test the latest linus tree with this series with Shuah's
config on qemu, and could not reproduced it. (I attached the log)
As you can see, with Shuah's config, histogram tests are marked UNSUPPORTED.

Of course, that is 4.12.0-rc5+ and kconfig is a bit tweaked(attached).
I'll try kselftest tree too.

Thank you,

> 
> Great to hear. I like reproducibility :-)
> 
> -- Steve
> 


-- 
Masami Hiramatsu <mhiramat@xxxxxxxxxx>
Wed Jun 14 02:02:06 UTC 2017
=== Ftrace unit tests ===
[1] Basic trace file check	[PASS]
[2] Basic test for tracers	[PASS]
[3] Basic trace clock test	[PASS]
[4] Basic event tracing check	[PASS]
[5] event tracing - enable/disable with event level files	[PASS]
[6] event tracing - restricts events based on pid	[PASS]
[7] event tracing - enable/disable with subsystem level files	[PASS]
[8] event tracing - enable/disable with top level files	[PASS]
[9] ftrace - function graph filters with stack tracer	[PASS]
[10] ftrace - function graph filters	[PASS]
[11] ftrace - function glob filters	[PASS]
[12] ftrace - function pid filters	[PASS]
[13] ftrace - test for function event triggers	[PASS]
[14] ftrace - function profiler with function tracing	[PASS]
[15] ftrace - test reading of set_ftrace_filter	[PASS]
[16] ftrace - test for function traceon/off triggers	[PASS]
[17] Test creation and deletion of trace instances while setting an event	[PASS]
[18] Test creation and deletion of trace instances	[PASS]
[19] Kprobe dynamic event - adding and removing	[PASS]
[20] Kprobe dynamic event - busy event check	[PASS]
[21] Kprobe dynamic event with arguments	[PASS]
[22] Kprobes event arguments with types	[PASS]
[23] Kprobe dynamic event with function tracer	[PASS]
[24] Kretprobe dynamic event with arguments	[PASS]
[25] Kretprobe dynamic event with maxactive	[PASS]
[26] Register/unregister many kprobe events	[PASS]
[27] event trigger - test event enable/disable trigger	[PASS]
[28] event trigger - test trigger filter	[PASS]
[29] event trigger - test histogram modifiers	[UNSUPPORTED]
[30] event trigger - test histogram trigger	[UNSUPPORTED]
[31] event trigger - test multiple histogram triggers	[UNSUPPORTED]
[32] event trigger - test snapshot-trigger	[PASS]
[33] event trigger - test stacktrace-trigger	[PASS]
[34] event trigger - test traceon/off trigger	[PASS]
[35] (instance)  Basic test for tracers	[PASS]
[36] (instance)  Basic trace clock test	[PASS]
[37] (instance)  event tracing - enable/disable with event level files	[PASS]
[38] (instance)  event tracing - restricts events based on pid	[PASS]
[39] (instance)  event tracing - enable/disable with subsystem level files	[PASS]
[40] (instance)  ftrace - test for function event triggers	[PASS]
[41] (instance)  ftrace - test for function traceon/off triggers	[PASS]
[42] (instance)  event trigger - test event enable/disable trigger	[PASS]
[43] (instance)  event trigger - test trigger filter	[PASS]
[44] (instance)  event trigger - test histogram modifiers	[UNSUPPORTED]
[45] (instance)  event trigger - test histogram trigger	[UNSUPPORTED]
[46] (instance)  event trigger - test multiple histogram triggers	[UNSUPPORTED]

# of passed:  40
# of failed:  0
# of unresolved:  0
# of untested:  0
# of unsupported:  6
# of xfailed:  0
# of undefined(test bug):  0

Attachment: mhiramat.config
Description: Binary data