Re: [PATCH V3 2/3] watchdog: uniphier: add UniPhier watchdog driver

[Masahiro Yamada]

Hayashibara-san


2017-06-13 10:14 GMT+09:00 Keiji Hayashibara
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 52a70ee..2a9d9a6 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -744,6 +744,17 @@ config ZX2967_WATCHDOG
>           To compile this driver as a module, choose M here: the
>           module will be called zx2967_wdt.
>
> +config UNIPHIER_WATCHDOG
> +       tristate "UniPhier watchdog support"
> +       depends on ARCH_UNIPHIER || COMPILE_TEST

This driver relies on syscon_node_to_regmap().
Could you also add "depends on OF && MFD_SYSCON" ?




> +       select WATCHDOG_CORE
> +       help
> +         Say Y here to include support watchdog timer embedded
> +         into the UniPhier system.
> +
> +         To compile this driver as a module, choose M here: the
> +         module will be called uniphier_wdt.
> +



-- 
Best Regards
Masahiro Yamada