Re: [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true

From: Hoeun Ryu
Date: Wed Jun 14 2017 - 02:54:03 EST


On Tue, 2017-06-13 at 22:27 -0700, Tony Lindgren wrote:
> Hi,
>
> * Hoeun Ryu <hoeun.ryu@xxxxxxxxx> [170612 18:18]:
> >
> > --- a/arch/arm/include/debug/omap2plus.S
> > +++ b/arch/arm/include/debug/omap2plus.S
> > @@ -58,11 +58,22 @@
> > Â
> > Â#define UART_OFFSET(addr) ((addr) & 0x00ffffff)
> > Â
> > +/*
> > + * Definition of ZIMAGE is in arch/arm/boot/compressed/Makefile.
> > + * Place the following block in .text section only when this file
> > is
> > + * included by arch/arm/boot/compressed/* to make it possible to
> > + * enable CONFIG_DEBUG_UNCOMPRESS and DEBUG in
> > arch/arm/boot/compressed/head.S
> > + * on OMAP2+ SoCs.
> > + */
> > +#ifndef ZIMAGE
> > Â .pushsection .data
> > +#endif
> > Âomap_uart_phys: .word 0
> > Âomap_uart_virt: .word 0
> > Âomap_uart_lsr: .word 0
> > +#ifndef ZIMAGE
> > Â .popsection
> > +#endif
> So I converted all these to use the 8250 debug_ll yesterday
> which should solve the DEBUG_UNCOMPRESS issue for you and
> allows us to remove this file. Will post the series shortly
> for testing with you in Cc after I've done a bit more testing
> here.

It sounds good.
patch 01 is dropped though, are you using the second patch ?
"[PATCH 2/2] arm:omap2+: drop dependence on DEBUG_OMAP2PLUS_UART for
DEBUG_UNCOMPRESS"

Thank you.

>
> Regards,
>
> Tony