Re: [PATCH v3 2/4] xen: add sysfs node for guest type

[Juergen Gross]

On 14/06/17 17:01, Boris Ostrovsky wrote:
> On 06/14/2017 11:00 AM, Juergen Gross wrote:
>> On 14/06/17 16:48, Boris Ostrovsky wrote:
>>>> diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c
>>>> index 84106f9c456c..d641e9970d5d 100644
>>>> --- a/drivers/xen/sys-hypervisor.c
>>>> +++ b/drivers/xen/sys-hypervisor.c
>>>> @@ -50,6 +50,18 @@ static int __init xen_sysfs_type_init(void)
>>>>  	return sysfs_create_file(hypervisor_kobj, &type_attr.attr);
>>>>  }
>>>>  
>>>> +static ssize_t guest_type_show(struct hyp_sysfs_attr *attr, char *buffer)
>>>> +{
>>>> +	return sprintf(buffer, "%s\n", xen_guest_type);
>>>> +}
>>>
>>> So I know I gave my R-b for this patch but can't we just key off
>>> xen_domain_type and not have xen_guest_type at all?
>> So we'd need to introduce XEN_PVH_DOMAIN and adjust xen_hvm_domain().
> 
> Can't we use xen_pvh_domain()?

Sure. I thought you meant to have the needed information all in
xen_domain_type.

I'll adjust the patch.


Juergen