Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number

From: Pali RohÃr
Date: Thu Jun 15 2017 - 09:59:17 EST


Mario, are you able to check if instance number passed to
wmi_evaluate_method in following dell WMI drivers is correct and should
be really 1?

I suspect that it should be zero, as instance number is indexed from
zero.

There is no comment in those dell WMI drivers why it is 1, nor what 1
means.

Ideally it needs to be checked in ACPI byte code, MOF file and WDG dump.

On Wednesday 14 June 2017 17:46:54 Pali RohÃr wrote:
> Function wmi_evaluate_method:
...
> alienware-wmi.c:
> instance=1 /* no comment why, guid=A70591CE-A997-11DA-B012-B622A1EF5492 */
> instance=1 /* no comment why, guid=A80593CE-A997-11DA-B012-B622A1EF5492 */
> instance=1 /* no comment why, guid=A70591CE-A997-11DA-B012-B622A1EF5492 */
...
> dell-wmi-led.c:
> instance=1 /* no comment why, guid=F6E4FE6E-909D-47cb-8BAB-C9F6F2F8D396 */

--
Pali RohÃr
pali.rohar@xxxxxxxxx