Re: [PATCH net-next] net: dsa: assign default CPU port to all ports

[Florian Fainelli]

On 06/15/2017 12:06 PM, Vivien Didelot wrote:
> The current code only assigns the default cpu_dp to all user ports of
> the switch to which the CPU port belongs. The user ports of the other
> switches of the fabric thus don't have a default CPU port.

Which would lead to a crash in dsa_master_netdev() :)

> 
> This patch fixes this by assigning the cpu_dp of all user ports of all
> switches of the fabric when the tree is fully parsed.
> 
> Fixes: a29342e73911 ("net: dsa: Associate slave network device with CPU port")
> Signed-off-by: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>

Thanks for this fix:

Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
-- 
Florian