Re: [PATCH 2/3] printk/console: Clean up logic around fallback console

From: Sergey Senozhatsky
Date: Thu Jun 15 2017 - 22:02:22 EST


On (06/15/17 17:31), Petr Mladek wrote:
[..]
> > diff --git a/include/linux/console.h b/include/linux/console.h
> > index b8920a031a3e..a2525e0d7605 100644
> > --- a/include/linux/console.h
> > +++ b/include/linux/console.h
> > @@ -127,7 +127,7 @@ static inline int con_debug_leave(void)
> > */
> >
> > #define CON_PRINTBUFFER (1)
> > -#define CON_CONSDEV (2) /* Last on the command line */
> > +#define CON_CONSDEV (2)
>
> The description is wrong. The name and the use suggest that
> it should be something like:
>
> #define CON_CONSDEV (2) /* Driver used by /dev/console */

that's better, indeed.

> There are some situations (bugs) where this is not true.

true.

-ss