Re: Crypto Fixes for 4.12
From: Theodore Ts'o
Date: Fri Jun 16 2017 - 08:50:25 EST
On Thu, Jun 15, 2017 at 11:01:18AM -0400, David Miller wrote:
> As a side note, ext4 does something similar with a private
> implementation, but it doesn't use something the evaluates to an
> alloca. Instead it uses a fixed 4-byte size for the shash context
> value in the on-stack declaration.
In ext4's case, we're doing it inside an inline function, and then
using the "return" value from inside the calling function. Assuming
that gcc actually inlines the function, are we in danger of tripping
over the bug?