Re: linux-next: build failure after merge of the akpm-current tree
From: Andrew Morton
Date: Fri Jun 16 2017 - 13:17:48 EST
On Thu, 15 Jun 2017 16:46:33 -0700 Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> On Thu, Jun 15, 2017 at 12:12 PM, Andrew Morton
> <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > On Wed, 14 Jun 2017 18:56:30 -0700 Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> >> >> Caused by commit
> >> >>
> >> >> 088a5ecf7581 ("include/linux/string.h: add the option of fortified string.h functions")
> >> >>
> >> >> We really need to fix all the known problems it detects *before*
> >> >> merging this commit ...
> >> >>
> >> >> I have reverted it for today.
> >> >
> >> > I am still needing to revert this every day ...
> >> I sent a series for -mm (or maintainers) to merge that should catch
> >> everything. Do you want me to carry it in my kspp tree instead? (My
> >> original intention was to carry all the fixes and the fortify patch in
> >> kspp but akpm took it into -mm somewhat unexpectedly, not that I'm
> >> complaining.)
> > This is all getting a bit foggy in my mind. Can we please have a full
> > resend of everything? Sufficient to hopefully produce a tree which has
> > no build-time or run-time regressions? Including the buildbot's
> > recently-reported alpha and xtensa issues?
> It's been sent a few times (and a few fixes have been collected in
> other trees already). What I've got in my for-next/kspp tree right now
> is all the fixes that haven't already been picked up by other tree
> maintainers, and I added the fortify patch itself to the end of the
> tree too now since sfr asked for that a few hours ago.
I think it's best to try to keep everything in a single tree, with
maintainer acks where possible.
I do this stuff all the time - please just send everything at me when
we think we have all the fixes and I'll sort it out.