Re: [PATCH v4 4/5] watchdog: provide watchdog_reconfigure() for arch watchdogs

From: Andrew Morton
Date: Fri Jun 16 2017 - 14:24:39 EST


On Fri, 16 Jun 2017 16:57:14 +1000 Nicholas Piggin <npiggin@xxxxxxxxx> wrote:

> After reconfiguring watchdog sysctls etc., architecture specific
> watchdogs may not get all their parameters updated.
>
> watchdog_reconfigure() can be implemented to pull the new values
> in and set the arch NMI watchdog.
>

I'll update the title and changelog to say "watchdog_nmi_reconfigure".

> --- a/kernel/watchdog.c
> +++ b/kernel/watchdog.c
> @@ -123,6 +123,11 @@ void __weak watchdog_nmi_disable(unsigned int cpu)
> {
> }
>
> +void __weak watchdog_nmi_reconfigure(void)
> +{
> +}

Can we please get some documentation in here describing what it's for?
How arch maintainers might use this? When and why it is called, what
it must do? etc.