Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework
From: Andrew Lunn
Date: Sun Jun 18 2017 - 10:53:21 EST
On Wed, Jun 14, 2017 at 12:10:29AM +0100, Salil Mehta wrote:
> This patch adds the support of the HNAE3 (Hisilicon Network
> Acceleration Engine 3) framework support to the HNS3 driver.
> Framework facilitates clients like ENET(HNS3 Ethernet Driver), RoCE
> and user-space Ethernet drivers (like ODP etc.) to register with HNAE3
> devices and their associated operations.
checkpatch throws out one warning in this file
CHECK: Comparison to NULL could be written "pos"
#3508: FILE: drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.h:572:
+ for (pos = (head).ring; pos != NULL; pos = pos->next)
This one seems valid. Not all checkpatch warnings are.