Re: [PATCH v5 3/6] reset: hide reset control arrays behind struct reset_control

From: Vivek Gautam
Date: Mon Jun 19 2017 - 09:06:42 EST

Hi Philipp,

On 06/19/2017 05:48 PM, Philipp Zabel wrote:
Hi Vivek,

On Tue, 2017-06-13 at 12:16 +0530, Vivek Gautam wrote:
@@ -102,18 +94,6 @@ static inline struct reset_control *__devm_reset_control_get(
return optional ? NULL : ERR_PTR(-ENOTSUPP);
-static inline
-int reset_control_array_assert(struct reset_control_array *resets)
- return 0;
-static inline
-int reset_control_array_deassert(struct reset_control_array *resets)
- return 0;
static inline struct reset_control_array *
This has to return just 'struct reset_control *'.
That should resolve kbuild errors.

Rest looks good to me.
Reviewed-by: Vivek Gautam <vivek.gautam@xxxxxxxxxxxxxx>
Thanks, I had already fixed this locally, prompted by the kbuild test
robot. I'll send a v6. I would like to merge this patch into the first
"reset: Add APIs to manage array of resets" patch, if that's ok with

You are right. It makes more sense to merge these two patches
if Jon finds it okay to put reset_control_array behind reset_control.

I am cool with squashing this patch.

Best regards


The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project