Re: [PATCH v5 2/3] PCI: Add tango PCIe host bridge support
From: Marc Zyngier
Date: Mon Jun 19 2017 - 11:58:41 EST
On 19/06/17 15:50, Marc Gonzalez wrote:
> On 07/06/2017 10:19, Marc Gonzalez wrote:
>> On 31/05/2017 15:33, Marc Gonzalez wrote:
>>> +static int tango_pcie_probe(struct platform_device *pdev)
>>> + int ret = -EINVAL;
>>> + void __iomem *base;
>>> + struct resource *res;
>>> + struct tango_pcie *pcie;
>>> + struct device *dev = &pdev->dev;
>>> + pr_err("MAJOR ISSUE: PCIe config and mem spaces are muxed\n");
>>> + pr_err("Tainting kernel... Use driver at your own risk\n");
>>> + add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);
>> Hello Bjorn,
>> In v4, your only comment was
>> "[muxing config and mem spaces] is a major issue and possibly even
>> a security problem [which requires at least an error message and a
>> kernel taint].
>> Were there any other issues with the host bridge support?
> Hello Bjorn,
> I imagine you are now only waiting for Marc Z's Ack of patch 3/3 ?
> (AFAIU, all issues have been addressed as of v8 3/3.)
Posting partial series is really not ideal, specially as you posted 3 of
them in less than 24 hours (and the latest was only 5 days ago).
The maintainer is not going to chase you about potentially missing
Jazz is not dead. It just smells funny...