Re: [PATCH] acer-wmi: Using zero as the first WMI instance number

From: Pali RohÃr
Date: Tue Jun 20 2017 - 16:46:22 EST


On Tuesday 20 June 2017 19:22:46 Andy Shevchenko wrote:
> On Tue, Jun 20, 2017 at 7:48 PM, Pali RohÃr <pali.rohar@xxxxxxxxx>
> wrote:
> > On Tuesday 20 June 2017 17:06:23 Lee, Chun-Yi wrote:
> >> Pali RohÃr found that there have some wmi query/evaluation
> >> code that they used 'one' as the first WMI instance number.
> >> But the number is indexed from zero that it's must less than
> >> the instance_count in _WDG.
> >>
> >> This patch changes those instance number from one to zero.
> >>
> >> Cc: Darren Hart <dvhart@xxxxxxxxxxxxx>
> >> Cc: Andy Shevchenko <andy@xxxxxxxxxxxxx>
> >> Cc: Pali RohÃr <pali.rohar@xxxxxxxxx>
> >> Signed-off-by: "Lee, Chun-Yi" <jlee@xxxxxxxx>
> >
> > Looks good, Reviewed-by: Pali RohÃr <pali.rohar@xxxxxxxxx>
>
> Unfortunately patchwork ignores this tag.
> So, in the future please:
> - put a tag on a separate line
> - do _not_ prepend it by any characters including white spaces
> (except new line :-) )

I have not known that those lines are parsed automatically.
Will do it in future!

> No need to resend this one.
>
> Pushed to testing, thanks!

--
Pali RohÃr
pali.rohar@xxxxxxxxx

Attachment: signature.asc
Description: This is a digitally signed message part.