Re: [PATCH 0/2] swait: add idle to make idle-hacks on kthreads explicit
From: Paul E. McKenney
Date: Wed Jun 21 2017 - 12:48:56 EST
On Tue, Jun 20, 2017 at 02:45:45PM -0700, Luis R. Rodriguez wrote:
> In this proper patch form I've made the non-timeout idle swait void.
> I've also integrated Paul's comment / ident changes, and added documentation
> as suggested by Boqun.
> Let me know if there are issue, otherwise, Paul feel free to take!
Nice docbook comments! I replaced my modified commits with your new ones,
queued for further review and testing.
Just out of curiosity, why the three-line swait_event_idle() with the
"break" statement instead of the two-line version with the inverted
condition? (I am fine either way, just curious.)
> Luis R. Rodriguez (2):
> swait: add idle variants which don't contribute to load average
> rcu: use idle versions of swait to make idle-hack clear
> include/linux/swait.h | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++
> kernel/rcu/tree.c | 11 +++++------
> 2 files changed, 60 insertions(+), 6 deletions(-)