Re: [PATCH] Convert BUG_ON to WARN_ON in bond_options.c

From: Michal Kubecek
Date: Thu Jun 22 2017 - 04:05:07 EST

On Thu, Jun 22, 2017 at 12:04:54AM +0100, Michael J Dilmore wrote:
> Is it worth at least wrapping BUG_ON in an unlikely macro then?

See BUG_ON() definition:

#define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while (0)

where HAVE_ARCH_BUG_ON is defined only on powerpc and mips. It makes
good sense, you don't want to BUG_ON() on a condition unless it's
extremely unlikely. (Except for debugging purpose but even then you
don't really care about fine optimization when you are going to oops.)

Michal Kubecek