Re: [PATCH][net-next] qtnfmac: fix uninitialized return code in ret

From: Sergey Matyukevich
Date: Thu Jun 22 2017 - 04:25:35 EST

> Not related to your patch but qtnf_map_bar() should be changed not to
> return NULL. When functions return both NULL and error pointers the
> NULL is supposed to be a special type of success return. Here it is
> just a fail return where we forgot to set the error code to

Thanks for reporting! FWIW it is not a bug, all the checks of pci maps
are in place. Though having both ERR_PTR and NULL in return indeed
looks confusing. We will add a fix in the upcoming cleanup series.